Fix: use public user_agent_entry connect parameter#64
Merged
Conversation
The databricks-sql-connector 4.0.1 release renamed the connect parameter `_user_agent_entry` to `user_agent_entry` and emits a deprecation warning when the old name is passed. Switch the dialect's `do_connect` listener and all call sites to the new name, pop any legacy `_user_agent_entry` callers still supply so it isn't forwarded, and bump the connector floor to >=4.0.1 to guarantee the new key is understood. Fixes #36.
jprakash-db
requested review from
deeksha-db,
gopalldb,
jackyhu-db,
jayantsing-db,
madhav-db,
samikshya-db,
shivam2680 and
vikrantpuppala
as code owners
|
Does this also resolve #45 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The databricks-sql-connector 4.0.1 release renamed the connect parameter
_user_agent_entrytouser_agent_entryand emits a deprecation warning when the old name is passed. Switch the dialect'sdo_connectlistener and all call sites to the new name, pop any legacy_user_agent_entrycallers still supply so it isn't forwarded, and bump the connector floor to >=4.0.1 to guarantee the new key is understood. Fixes #36.